Fix StatementList not reindexing associative arrays #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thiemowmde can you look into clarifying the contract of the class with regards to the array keys, and if we cannot push this responsibility to the user of the class? |
JeroenDeDauw
added a commit
that referenced
this pull request
Nov 26, 2014
Fix StatementList not reindexing associative arrays
This was referenced Nov 27, 2014
Done, see #322. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced in #285 (released with 2.4.0) but had no test, unfortunately. It made tests fail in WikibaseDataModelSerialization.