Add EntityIdPager from Wikibase\Repo\Store #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple interface for services that allow paging through EntityIds.
JeroenDeDauw
approved these changes
Oct 13, 2016
| * @license GPL-2.0+ | ||
| * @author Daniel Kinzler | ||
| */ | ||
| interface EntityIdPager { |
There was a problem hiding this comment.
Might be worth changing so it implements the Fetcher interface from https://github.com/JeroenDeDauw/BatchingIterator, which then allows for having an Iterator and hiding that a fetcher is used
There was a problem hiding this comment.
I'm open to that, but let's see what others say. Also means a new dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple interface for services that allow paging through EntityIds.