Move EntityIdComposer from Wikibase to DataModelServices #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladsgroup
force-pushed
the
entity_id_composer
branch
from
ecbf194
to
64cd643
Compare
Ladsgroup
force-pushed
the
entity_id_composer
branch
from
e22b398
to
71e7ee6
Compare
thiemowmde
suggested changes
Jun 23, 2017
| * | ||
| * Meant to be the counterpart for @see Int32EntityId::getNumericId, as well as an extensible | ||
| * replacement for @see LegacyIdInterpreter::newIdFromTypeAndNumber. | ||
| * |
There was a problem hiding this comment.
Can you add a @since tag?
| /** | ||
| * @covers Wikibase\DataModel\Services\EntityId\EntityIdComposer | ||
| * | ||
| * @group Wikibase |
There was a problem hiding this comment.
Please remove, I think we don't use @group tags in this component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.