Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-generated @param-only PHPDoc blocks that add zero information #184

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

thiemowmde
Copy link
Contributor

This patch removes auto-generated PHPDoc blocks that contain nothing but a sequence of @param lines that literally repeat what the function header below contains. These blocks add zero additional information, but clutter the code and need to be maintained. This patch does not touch PHPDoc blocks when one of the @param lines contains an actual comment behind the variable name, or when one of the types is not a class name.

See https://gerrit.wikimedia.org/r/360814 for the same patch in the Wikibase.git code base.

@Ladsgroup
Copy link
Contributor

Can you rebase?

@thiemowmde
Copy link
Contributor Author

Something was failing for a reason I did not understood. I hope it disappears with the rebase I did now.

@Ladsgroup Ladsgroup merged commit d1428c3 into master Aug 3, 2017
@Ladsgroup Ladsgroup deleted the redundantDocs branch August 3, 2017 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants