Drop hhvm from travis because broken #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WMF is still on hhvm, I suggest not dropping it until WMF has migrated to php7 |
|
It's either dropping this or fixing the issue. I think fixing the issue would be a waste of time. Don't let me stop you though. If you think you can justify spending time on it, by all means go for it. |
What exactly is broken? What would be needed to fix it properly? I had a brief look at the error messages in #205 and it seems the issue might as well be fixable by temporarily disabling/removing PHPMD. |
thiemowmde
added a commit
that referenced
this pull request
Dec 3, 2018
Possible alternative for #206. For now this is a test to see if the lamps go green or red with this change. Feel free to do whatever you like with this pull request (amend, close).
|
The PHPMD idea seems to work, see #207. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All new PRs are red now: