Add SeekableEntityIdPager #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of https://phabricator.wikimedia.org/T219894 (though the ticket wont tell you anything about this commit) In Wikibase Repo we have SqlEntityIdPager, which gets used by the term rebuilding script. In the new term rebuilding script we need the same stuff. To test that we need to inject a test double. There is MockEntityIdPager, though it just implements EntityIdPager, while our implementation needs extra methods from SqlEntityIdPager that are not in the interface. These extra methods are added in SeekableEntityIdPager. InMemoryEntityIdPager is provided as test double and is a modified version of MockEntityIdPager, which is now also tested. The old term rebuilding code was not tested at all, which is why we run into this missing interface now.
JeroenDeDauw
force-pushed
the
SeekableEntityIdPager
branch
from
ff190bc
to
f1ad8af
Compare
AlaaSarhan
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://phabricator.wikimedia.org/T219894
(though the ticket wont tell you anything about this commit)
In Wikibase Repo we have SqlEntityIdPager, which gets used by the
term rebuilding script. In the new term rebuilding script we need
the same stuff. To test that we need to inject a test double.
There is MockEntityIdPager, though it just implements EntityIdPager,
while our implementation needs extra methods from SqlEntityIdPager
that are not in the interface.
These extra methods are added in SeekableEntityIdPager.
InMemoryEntityIdPager is provided as test double and is a modified
version of MockEntityIdPager, which is now also tested.