Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop accepting null for term type and lang in TermBuffer::prefetchTerms() #229

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Stop accepting null for term type and lang in TermBuffer::prefetchTerms() #229

merged 1 commit into from
Jan 23, 2020

Conversation

Ladsgroup
Copy link
Contributor

It has caused more harm than good. Lots of places load all terms to
use very small bits of it. They are fixed now.

@Ladsgroup
Stop accepting null for term type and lang in TermBuffer::prefetchTer…
d021d6a 
…ms()

It has caused more harm than good. Lots of places load all terms to
use very small bits of it. They are fixed now.
@addshore
Copy link
Contributor

Going to need to end up fixing a bunch of usages with this change.
But I'm very pro being explicit here.

@Ladsgroup Ladsgroup merged commit 303b7f4 into master Jan 23, 2020
@Ladsgroup Ladsgroup deleted the no_t0_nulls branch January 23, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswerkmeister lucaswerkmeister lucaswerkmeister approved these changes

@addshore addshore addshore approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ladsgroup @addshore @lucaswerkmeister