Add interfaces for writing Item/Property term stores #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tiny interfaces are meant to eventually replace wikibase/term-store.
Ladsgroup
reviewed
Feb 12, 2020
| use Wikibase\DataModel\Entity\ItemId; | ||
| use Wikibase\DataModel\Term\Fingerprint; | ||
|
|
||
| interface ItemTermStoreWriter { |
There was a problem hiding this comment.
BTW. This is going to replace EntityTermStoreWriter interface
There was a problem hiding this comment.
EntityTermStoreWriter is generally defined on EntityId/ EntityDocument, it might have a use for other entity types.
Ladsgroup
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tiny interfaces are meant to eventually replace
wikibase/term-store.