Add SiteLinkLookup from Wikibase Lib

[Benestar]

No description provided.

[JeroenDeDauw]

$pageTitle is a MediaWiki concept. Should not be in this component

[Benestar]

That's just the naming of the variable. It's obvious that the method is just another version of getItemIdForSiteLink. We can however adjust the naming of the variables. That doesn't really change the interface though.

[addshore]

We could just kill the getItemIdForLink in the interface?

[Benestar]

Even better idea @addshore #killallthethings

[addshore]

hah, I think I am getting a name for myself when it comes to killing things...
Either kill it or rename the params to $siteId and $pageName as in https://github.com/wmde/WikibaseDataModel/blob/master/src/SiteLink.php#L47

[Benestar]

/me is looking for usages

[Benestar]

We should still have the method in there. There are cases where we deal with title objects and site ids independently and we perhaps don't want to construct a SiteLink object for no reason.

[JeroenDeDauw]

I'm looking through the git history for this interface out of curiosity. Originally it just had

public function getConflictsForItem( Item $item );
public function getItemIdForLink( $globalSiteId, $pageTitle );

First degradation happened in https://gerrit.wikimedia.org/r/#/c/32172/4/lib/includes/store/SiteLinkLookup.php by me :) After that it grew more and some stuff got removed

[JeroenDeDauw]

I'm thinking this interface is probably not well segregated, and should be split based on the users of the methods. While for the initial move from WB.git we figured to just move and improve later, I suspect it's easier now to first improve and then move. This avoids forcing breaking releases of this component and should be easy enough to manage, as we are not moving dozens of things and in the process of introducing new component.

Does someone know if any of the interfaces methods are frequently used together, or used together at all?

[thiemowmde]

This is a weird interface. An array with three numerically indexed elements? I do not think such an interface should be in this generic services component. This sounds like a concept that's specific to Wikibase.git and should stay there.

[JeroenDeDauw]

No changes since 2015. Please reopen if needed for current goals