Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with new API updates #39

Merged
merged 1 commit into from
May 31, 2021
Merged

Update readme with new API updates #39

merged 1 commit into from
May 31, 2021

Conversation

toban
Copy link
Contributor

@toban toban commented May 28, 2021

  • Item statement reconciliation
  • Property lookup by label

@guergana
Copy link
Contributor

guergana commented May 28, 2021

It looks great 😍 Tho, as per the ticket I would add a mention to Federated properties to the list named "This code is currently work in progress and some things are thus known to not to work:"

Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great heart_eyes Tho, as per the ticket I would add a mention to Federated properties to the list named "This code is currently work in progress and some things are thus known to not to work:"

Also, several other items of that list should be removed by now.

README.md Outdated
@@ -115,6 +115,62 @@ Follow the instructions [here](https://www.mediawiki.org/wiki/OAuth/Owner-only_c

For an example on how to request a edit token and make an authenticated request using OAuth see the [example python script](example/oauth/main.py).

## Property lookup by name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both “property lookup by name” and “statement reconciliation” should be subsections of the minimal input format, since we don’t support them for the full input format.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@guergana guergana force-pushed the update-readme branch 3 times, most recently from a543020 to 575251a Compare May 28, 2021 16:04
README.md Outdated
@@ -9,7 +9,8 @@ This code is currently **work in progress** and some things are thus **known to
* 0.0.1/minimal statement value parsing options (such as language), could lead to "interesting" things
* Anything to do with references, qualifiers
* Statement ranks and sitelink badges may have an undetermined behavior
* Editing always has a fixed user and summary currently, and token validation etc does not happen
* Property lookup by name and Statement reconciliation are currently only supported for the minimal input format.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I don’t think that’s a limitation? It wouldn’t make sense to support them in the full input format IMHO, that format is supposed to be identical to the Wikibase JSON.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 ok.

- Item statement reconciliation
- Property lookup by label (does not work with FP)
@toban
Copy link
Contributor Author

toban commented May 31, 2021

Nice, reads and looks good to me 👍

@toban toban merged commit c22fa55 into main May 31, 2021
@toban toban deleted the update-readme branch May 31, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants