fix division by zero in UI validation #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paymenIntervalInMonths value being 0 is currently not reproducable as its initial value is -1 and the UI validation prevents it from entering a state where it could become 0. This additional check will prevent the interval field from being validated before it was selected because there is a check now for its correct default value (-1). https://phabricator.wikimedia.org/T215163
gbirke
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paymenIntervalInMonths value being 0 is currently not reproducable
as its initial value is -1 and the UI validation prevents it from entering
a state where it could become 0.
This additional check will prevent the interval field from being validated
before it was selected because there is a check now for its correct
default value (-1).
https://phabricator.wikimedia.org/T215163