Fix devision by zero PHP notice #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
approved these changes
Mar 29, 2019
| @@ -28,6 +28,10 @@ public function validate( ValidateFeeRequest $request ): ValidateFeeResult { | |||
| $this->paymentIntervalInMonths = $request->getPaymentIntervalInMonths(); | |||
| $this->applicantType = $request->getApplicantType(); | |||
|
|
|||
| if ( $this->paymentIntervalInMonths === 0 ) { | |||
There was a problem hiding this comment.
Maybe make this < 1 instead, as negative intervals make no sense here, but are the default value on the client side (although wmde/fundraising-application#1452 makes sure we don't send it any more).
There was a problem hiding this comment.
Don't forget the test case if you do :)
The client side validation prevents negative intervals from occuring now, but they should be caught here as well, just in case. https://phabricator.wikimedia.org/T215163
|
This is definitely fine, though I'd have extracted the request creation into some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T215163
PP'd with Corinna