Clear libxml errors before using them #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the FileImporter project I got failing hamcrest test due to totally unrelated leftover libxml errors form other parts of the code. Clearing the errors before listening and depending on them could be a solution to that. Although this would not be needed if errors are cleared correctly in other code places, it was really a pain to debug this. See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/442895/14 https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/7215/console https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/445430/
bekh6ex
suggested changes
Jul 18, 2018
This test will trigger libxml errors from parsing a broken DOM that then are left unhandled to see it the hamcrest assertion will be influenced by that.
Good point, test added :-)! |
addshore
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the FileImporter project I got failing hamcrest test due to totally
unrelated leftover libxml errors form other parts of the code. Clearing the
errors before listening and depending on them could be a solution to that.
Although this would not be needed if errors are cleared correctly in other code
places, it was really a pain to debug this.
See
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/442895/14
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/7215/console
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/445430/