Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear libxml errors before using them #14

Merged
merged 3 commits into from Aug 2, 2018
Merged

Clear libxml errors before using them #14

merged 3 commits into from Aug 2, 2018

Commits on Jul 17, 2018

  1. Clear libxml errors before using them 

    In the FileImporter project I got failing hamcrest test due to totally
unrelated leftover libxml errors form other parts of the code. Clearing the
errors before listening and depending on them could be a solution to that.

Although this would not be needed if errors are cleared correctly in other code
places, it was really a pain to debug this.

See
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/442895/14
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/7215/console
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FileImporter/+/445430/
    @WMDE-Fisch
    WMDE-Fisch committed Jul 17, 2018
    Copy the full SHA
    949032c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Add test for unrelated leftover libxml errors 

    This test will trigger libxml errors from parsing a broken DOM that
then are left unhandled to see it the hamcrest assertion will be
influenced by that.
    @WMDE-Fisch
    WMDE-Fisch committed Jul 19, 2018
    Copy the full SHA
    e6f7db6 View commit details
    Browse the repository at this point in the history

  2. Fix PHPCS issues

    @WMDE-Fisch
    WMDE-Fisch committed Jul 19, 2018
    Copy the full SHA
    6960152 View commit details
    Browse the repository at this point in the history