-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style adjustments #263
Style adjustments #263
Conversation
The linter rule does not allow using 'rem' as a unit, i've disabled it. font-size for the copyright message should be 13px, the rem in this case is relativly calculated from 1rem which is 16px. margins between elements adapted to represent 16px as well. The main content wrapper will get a top margin of 0.5rem so that the gap between search-exiting or anonymous edit message and the main form always remains 1.5rem. Bug: T312652
✅ The font-size of the copyright message is at least 13px **I noticed that the copyright message still has a margin of 1em applied to it. This doesn't cause any problems because it overlaps with the 1rem margin applied to all elements. It might be a good idea to remove that just for consistency. Tested on Chrome 104, Safari 15.6 and Firefox 103 on macOS Monterey. |
|
Answering inline, @chukarave.
Got it! Is there a way I can check the Gerrit patch? I'm not sure where to find a Netlify link.
I think that removing the bottom margin makes sense, since it's not contributing to spacing the layout. We might need to keep the 1rem margin at the top to ensure that the last field and the message have proper separation between them. This approach would allow us to maintain proper spacing between the last field and the button if the text were removed. |
as we discussed, this is not part of the Vue app so will be visible on Beta once merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking great! Thanks, @chukarave 💯
The linter rule does not allow using 'rem' as a unit,
i've disabled it.
font-size for the copyright message should be 13px, the
rem in this case is relativly calculated from 1rem which is 16px.
margins between elements adapted to represent 16px as well.
The main content wrapper will get a top margin of 0.5rem
so that the gap between search-exiting or anonymous edit message
and the main form always remains 1.5rem.
Bug: T312652