This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Output Link to ticket in found address CSV #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output CSV can now contain a ticket ID. Move CSV generation to output class. Delete CSVSourceDataReader - exported CSV has no ticket id and we're using the database now.
JeroenDeDauw
reviewed
Feb 3, 2017
|
|
||
| trait CSVFormatter { | ||
|
|
||
| protected function formatAsCSV( array $row ): string { |
|
|
||
| namespace WMDE\OtrsExtractAddress\UseCases\ExtractAddress; | ||
|
|
||
| trait CSVFormatter { |
There was a problem hiding this comment.
Why trait and not composition? If you don't want to inject the thing I'd still make a class and just instantiate it where it is used.
| if ( $v ) { | ||
| return '"'. str_replace( '"', '""', $v ) . '"'; | ||
| } else { | ||
| return ''; |
There was a problem hiding this comment.
Oh noez! an if-esle. You can use a guard followed by a return
|
|
||
| private $outputStream; | ||
|
|
||
| public function __construct( $outputStream ) { |
There was a problem hiding this comment.
Is it still not possible to type hint this in PHP 7.1?
There was a problem hiding this comment.
Nope, resources (DB resource, file handler resource), can't be type hinted yet. But I made another commit where I replace the resource with SplFileObject.
Convert trait to class and use that class internally. Remove superfluous `else`.
|
+0.82 |
Resources can't be type hinted yet in PHP (at least until 7.1), see http://stackoverflow.com/questions/40637939/typehinting-for-filehandle-as-argument-in-function So we use SplFileObject instead.
JeroenDeDauw
reviewed
Feb 3, 2017
| $this->outputStream = $outputStream; | ||
| $this->csvFormatter = new CSVFormatter(); | ||
| } | ||
|
|
||
| public function writeRow( SourceData $data, string $errorMsg ) { | ||
| // TODO add option to skip "not found" messages and export only other messages | ||
| fwrite( $this->outputStream, $this->csvFormatter->formatAsCSV( [ | ||
| $this->outputStream->fwrite( $this->csvFormatter->formatAsCSV( [ |
|
I don't see any obvious issues but cannot +2 without understanding the tasks and tools involved here more. Presumably @KaiNissen is better up to speed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output CSV can now contain a ticket ID.
Move CSV generation to output class.
Delete CSVSourceDataReader - exported CSV has no ticket id and we're
using the database now.