Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Modify query and store to select or omit the labels #133

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

guergana
Copy link
Contributor

@guergana guergana commented Jan 7, 2021

added omitLabels to rootState and updated files that use the state

@guergana guergana changed the title Modify query and store to select or omit the labels [WiP] Modify query and store to select or omit the labels Jan 7, 2021
@guergana guergana changed the title [WiP] Modify query and store to select or omit the labels Modify query and store to select or omit the labels Jan 7, 2021
Copy link
Collaborator

@micgro42 micgro42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work! One small comment about a test, then it is good to go!

tests/unit/store/mutations.spec.ts Show resolved Hide resolved

mutations.setOmitLabels( state, omitLabels );

expect( state.omitLabels ).toStrictEqual( omitLabels );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is just a plain boolean, we can use .toBe( here instead of .toStrictEqual(

@guergana guergana merged commit 0334050 into master Jan 8, 2021
@guergana guergana deleted the labelOptout-store branch January 8, 2021 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants