This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Append property id to anyvalue to avoid clashes #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When several properties have been chosen with "regardless of value" Bug: T271903
Ladsgroup
requested review from
guergana and
micgro42
and removed request for
guergana
guergana
reviewed
Jan 14, 2021
| } ); | ||
|
|
||
| it( 'builds a query from multiple conditions, one matching and one regardless', () => { | ||
| const expectedQuery = | ||
| `SELECT ?item WHERE { | ||
| ?item (p:P666/ps:P666) "blah". | ||
| ?item (p:P66/ps:P66) _:anyValue. | ||
| ?item (p:P66/ps:P66) _:anyValueP66. |
There was a problem hiding this comment.
Can there be the case that a user searches for the same property in two different conditions? 🤔
There was a problem hiding this comment.
Currently no, we might have it once we have nesting but that requires a much bigger refactor.
guergana
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When several properties have been chosen with "regardless of value"
Bug: T271903