Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version for tainted references #13

Merged
merged 4 commits into from
Dec 12, 2019
Merged

Conversation

tarrow
Copy link
Contributor

@tarrow tarrow commented Nov 21, 2019

Add methods targeting a specific statement in a statementGroup to:

  • click edit
  • set value
  • click save

Add methods targeting a specific statement in a statementGroup to:
* click edit
* set value
* click save
@tarrow
Copy link
Contributor Author

tarrow commented Nov 21, 2019

Lets call this a WIP for now

Copy link
Contributor

@chukarave chukarave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am generally happy with this.

@tarrow tarrow force-pushed the TaintedRefsInit branch 2 times, most recently from eec3d32 to dc72a41 Compare December 3, 2019 10:48
Add an intital page section for tainted-refs. Include as a mixin
in the item page.

Currently only includes getter for the tainted icon
Introduces:
* Utilty methods in main statement section
* Tainted-refs page section
@tarrow tarrow changed the title Add methods for editing and saving statement values Release version for tainted references Dec 10, 2019
@mariushoch mariushoch merged commit 9ac0a00 into master Dec 12, 2019
@mariushoch mariushoch deleted the TaintedRefsInit branch December 12, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants