Skip to content
This repository has been archived by the owner on Jul 4, 2021. It is now read-only.

Add wikibase:1.31 #52

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Add wikibase:1.31 #52

merged 2 commits into from
Dec 19, 2018

Conversation

Ladsgroup
Copy link
Contributor

Bug: T197212

@Ladsgroup
Copy link
Contributor Author

The reason it fails is that the bundle can't find the base 1.31 image because it's not yet pushed to docker hub. I can split this PR to make sure first the base gets merged and then the bundle one.

@addshore
Copy link
Contributor

Hmm,, but the first image should be tagged with wikibase/wikibase:1.31 when built? No?

addshore
addshore reviewed Dec 19, 2018
View reviewed changes
wikibase/1.31/.travis/build-deploy.sh Outdated
#Oneline for full directory name see: https://stackoverflow.com/questions/59895/getting-the-source-directory-of-a-bash-script-from-within
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
set -e
docker build --pull "$DIR/../base" -t wikibase/wikibase:1.31 -t wikibase/wikibase:1.31-base -t wikibase/wikibase:latest -t wikibase/wikibase:latest-base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the -t wikibase/wikibase:1.31 on this line should do that

@tarrow
Copy link
Contributor

tarrow commented Dec 19, 2018

I think as @addshore suggested we should probably remove all the --pulls

@addshore addshore merged commit a865f0a into master Dec 19, 2018
@addshore addshore deleted the T197212 branch December 19, 2018 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@addshore addshore addshore left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Ladsgroup @addshore @tarrow