ADR0012 - versioning scheme & branching #59
Conversation
docs/adr/0012-versioning.md
Outdated
|
|
||
| As for the tag itself we also need to decide on version-numbering scheme for differentiating releases where the WMF version number does not change. Seeing that MediaWiki is already using the semantic versioning for incrementing their (maintenance releases) releases in between new release branches being cut it makes sense for wikibase to adopt a similar process as we will still rely on the release branches for future releases. | ||
|
|
||
| Example: The patch release following 1.35 (1.35.0) will be known as 1.35.1 |
There was a problem hiding this comment.
I have some concerns that this could be confusing. Imagine the following situation:
We release 1.35.0 which contains Mediawiki 1.35.0.
We release 1.35.1 which contains Mediawiki 1.35.0 and also some additional extensions and bug fix to Quickstatements.
WMF releases a 1.35.1 security patch release of Mediawiki
We release 1.35.2 which contains Mediawiki 1.35.1 (and the previous changes mentioned)
This sound to me like we might confuse ourselves let-alone users.
There was a problem hiding this comment.
My strawman proposed solution stolen from the ticket is:
We release 1.35.0-wmde0 which contains Mediawiki 1.35.0.
We release 1.35.0-wmde1 which contains Mediawiki 1.35.0 and also some additional extensions and bug fix to Quickstatements.
WMF releases a 1.35.1 security patch release of Mediawiki
We release 1.35.1-wmde0 which contains Mediawiki 1.35.1 (and the previous changes mentioned)
There was a problem hiding this comment.
All very valid points. I've updated the ADR with the first argument and adopted your suggestion with a slight modification.
|
Should I just bump this to accepted now? |
IMO, go for it. |
Co-authored-by: Leszek Manicki <leszek.manicki@wikimedia.de>
|
|
||
|
|
||
| Example: A Wikibase release based on 1.35.0 would be versioned as 1.35.0-wmde.0 | ||
| Example: A queryservice frontend release would be versioned wmde.0, wmde.1 etc. |
https://phabricator.wikimedia.org/T273889