Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace table with wikit component #117

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Replace table with wikit component #117

merged 3 commits into from
Sep 29, 2021

Conversation

itamargiv
Copy link
Member

This change replaces the local table component, with the up streamed WiKit version.

Bug: T291079

Silvan-WMDE
Silvan-WMDE approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@Silvan-WMDE Silvan-WMDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code - and the table still works \o/

@itamargiv itamargiv merged commit c2280d1 into main Sep 29, 2021
@itamargiv itamargiv deleted the client/replace-table-with-wikit-component branch September 29, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silvan-WMDE Silvan-WMDE Silvan-WMDE approved these changes

@guergana guergana Awaiting requested review from guergana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itamargiv @Silvan-WMDE