Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Testing (SQLite Mock) #15

Merged
merged 7 commits into from Jul 15, 2021
Merged

Integration Testing (SQLite Mock) #15

merged 7 commits into from Jul 15, 2021

Conversation

itamargiv
Copy link
Member

No description provided.

@guergana guergana marked this pull request as ready for review July 13, 2021 14:51
itamargiv
itamargiv commented Jul 13, 2021
View reviewed changes
Copy link
Member Author

@itamargiv itamargiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! I'm still missing a test for the three remaining auth routes, but I think we can put them in another PR. There's one last thing to be done here, and then we're good to go. (Also, I cannot approve this, since I created the PR 😬 )

tests/Feature/ApiRouteTest.php Show resolved Hide resolved
tests/Feature/WebRouteTest.php Show resolved Hide resolved
@itamargiv
Copy link
Member Author

Oh, and one last thing, we need to update the GitHub action to run the tests, give me a shout if you need help doing that, I'm always happy to contrib.

@guergana guergana force-pushed the testing-sqlite branch 2 times, most recently from e4d7902 to 963ddbb Compare July 15, 2021 09:24
itamargiv
itamargiv commented Jul 15, 2021
View reviewed changes
Copy link
Member Author

@itamargiv itamargiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TOTALLY approved! (only… I can't really approve because I opened the PR)

guergana
guergana approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesum!

@guergana guergana merged commit e2554dd into main Jul 15, 2021
@guergana guergana deleted the testing-sqlite branch July 15, 2021 10:19
@itamargiv itamargiv mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guergana guergana guergana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@itamargiv @guergana @Silvan-WMDE