-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the language selector to detect autonym by exonym #883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works great! One exception: I think we need to have a debounce period for API searches, right now we send an API call immediately after key down, but we need to call the API if the user doesn't write for some period like 300ms.
@hasanakg this is a great point, I added debouncing (naming advice welcomed) but to avoid displaying the "Language not available" message often while the input is still being typed in I set it to 200ms. what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to solve the empty input problem that I mentioned in the code comments.
@chukarave as much as I would have liked to come up with the solution for the svg-jest mock transformer by myself, i actually found it in this github issue thread, in case you wanna take a look: jpkleemans/vite-svg-loader#35 (comment) |
705d92d
to
9d7a64e
Compare
@guergana nice! thanks. it's pretty straight forward, I like that it doesn't require installing any svg tansformer packages. |
This PR adds the ability to search for a language name in any language and have the autonym suggested (same behavior as Wikidata).
Bug: T353727