This repository has been archived by the owner on Jan 18, 2019. It is now read-only.
fixed handling of doubles #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. |
|
@wmjordan - Can I talk you into pushing out another Nuget package with this fix? You'll need to roll the version number. Thanks. |
|
Thanks for reminding me. I've just uploaded the new NuGet package. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug with the unboxing of a
longas adouble. I added a test to go with my fix. I also added some other overloads to the JSON file.Also, I noticed while I was in there that we use dictionary lookups on object instances before populating them. That will break any object designed to be used as a dictionary key.