Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeFlag 031031 is missing EntryName value #80

Closed
amilan17 opened this issue Jun 16, 2021 · 4 comments · Fixed by #96
Closed

CodeFlag 031031 is missing EntryName value #80

amilan17 opened this issue Jun 16, 2021 · 4 comments · Fixed by #96
Assignees
Milestone

Comments

@amilan17
Copy link
Member

amilan17 commented Jun 16, 2021

Branch

https://github.com/wmo-im/BUFR4/tree/issue80

Summary and purpose

An issue (#76) was submitted by https://github.com/TheRed86, because the XML representation of 0 31 031 is missing an  XML tag: <EntryName_en>.  The Bit No. 1 does not have a name in manual nor in the the CSV.  

Action proposed

  1. add name if needed
  2. modify XML generation so that it doesn't completely omit missing values
@amilan17
Copy link
Member Author

amilan17 commented Oct 6, 2021

Jeff recommends combining into one field.

amilan17 added a commit that referenced this issue Nov 10, 2021
@amilan17
Copy link
Member Author

amilan17 commented Nov 10, 2021

moved the 'description' into the EntryName column

    <FXY>031031</FXY>
    <ElementName_en>Data present indicator</ElementName_en>
    <CodeFigure>1</CodeFigure>
    <EntryName_en>0 = Data present, 1 = Data not present</EntryName_en>
    <Status>Operational</Status>

@amilan17
Copy link
Member Author

@jitsukoh I think the branch is ready.

@jitsukoh
Copy link

@amilan17 I do not completely understand how it works but I trust you!

@amilan17 amilan17 linked a pull request Nov 11, 2021 that will close this issue
amilan17 added a commit that referenced this issue Dec 21, 2021
@amilan17 amilan17 closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants