-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add properties.metadata_id #31
Conversation
38087b1
to
42d2319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review ok, only for
standard/recommendations/core/REC_metadata_id.adoc
--> copy and paste error from integrity?
delete "...consisting of a +method+
property identifying the hashing method (md5
, sha256
, sha512
) and a +value+
property of the hashing result, when it can be easily derived."
Metadata id concept change in examples from e.g.
old - urn:x-wmo:md:int.wmo.wis::ISMD01EDZW (...int.wmo.wis for international exchanged)
new - urn:x-wmo:md:fra:meteo-france:gap123 (...country:centre-id...)
In my opinion a useful change but I see it here for the first time consciously (so only intended as a comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When it concerns metadata_id, we have touched on such a possibility during the telco, but I do not think we have agreed on that. My concern is, that this is not lowering the barrier (to enter WIS) but heightening it. It is another element that needs to be appropriately maintained in the configuration of the notification publishing software and has little practical value. I think that the data_id (topicHierarchy) provides sufficient linkage between the data and the metadata.
@antje-s thanks, fixed copy/paste typo. The metadata identifier definition is defined in WCMP2 in https://wmo-im.github.io/wcmp2/standard/wcmp2-DRAFT.html#_identifier |
|
Not sure...is "SHOULD" enough? (perhaps we need a SHALL) |
I vote for "SHOULD" in this case. Quite a number of properties are optional, including geometry and date/time, to lower the barrier for entry into WIS 2.0. This is the same situation. The metadata already points to the service/broker, now if we imposed that each notification points back to the metadata record it would effectively become a double linkage - which is significantly more difficult to maintain. Links tend to "rot", and double linkages doubly so :-) |
Update: discussions with @golfvert indicate support for SHOULD. Let's move ahead w/ SHOULD and consider applying as a KPI. |
Implements #25