Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify WNM major version change requirement #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tomkralidis
Copy link
Collaborator

@tomkralidis tomkralidis commented Jan 16, 2024

Clarify that a major change to WNM would propagate a major version change to WTH.

Co-authored-by: Anna Milan <amilan@wmo.int>
@tomkralidis
Copy link
Collaborator Author

After further discussion with @josusky, it is proposed to defer until initial publication of WNM. As a result:

  • open a new issue for post INFCOM discussion
  • update this PR to remove the Requirement

@antje-s
Copy link
Contributor

antje-s commented Jan 17, 2024

What are the reasons for removing the requirement?
In my view, the WTH version change is important for major changes in the notification content so that subscribers can check that the new payload can be processed correctly and completely or can make the necessary adjustments to their implementation

Copy link
Contributor

@antje-s antje-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates in REQ_versioning.adoc are ok

@josusky
Copy link
Contributor

josusky commented Jan 17, 2024

(Commenting once again using the right account):

What are the reasons for removing the requirement?
Maybe Tom can paste here the whole discussion, but the main points are:

Change of the WNM (notification format) is very unlikely in the near future.
We do not have an agreed migration strategy for such change (it can leverage change of WTH version but not necessary).
There might be some other situations when change of the WTH will be needed but perhaps instead of trying to enumerate all possible situations as SHALLs we could add a permission (MAY) to change the version number - for good reason and with appropriate advance notification.
No need solve this in the current version of the specification.
However, we should add this into agenda for a team meeting after the INFCOM-3.

Copy link
Contributor

@josusky josusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned, this needs more discussion. Strong relation between WNM version change and WTH version is not justified at the moment.

@amilan17 amilan17 self-requested a review February 2, 2024 12:48
@amilan17
Copy link
Member

amilan17 commented Feb 2, 2024

@tomkralidis are we removing this requirement entirely? Or keeping the revisions as proposed in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants