Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more accurate error message if loading of noxfile runs into error #272

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Use a more accurate error message if loading of noxfile runs into error #272

merged 1 commit into from
Jan 16, 2020

Conversation

jaikiran
Copy link
Contributor

I had a noxfile.py which looked something like:

import os
os.makedirs(some_already_existing_path)
....
# all other nox sessions

While running this with nox, I kept running into an odd:

nox > Noxfile /home/me/noxfile.py not found

Pretty sure the file was there and I also checked the file permissions and other usual suspects. Couldn't make much sense out of it so looked into the source code of nox and realized that this error message is inaccurate. In fact, this has been reported as an issue at #248.

The commit in this PR, changes the log message to more accurately describe what went wrong and also include a trace back of the actual exception to help diagonize the issue. Any reviews/suggestions?

P.S: I took the liberty to open this PR since it's been a while since that issue was reported, but if the volunteer who volunteered to fix this already had done some work on it that can be merged soon, I will gladly close this one.

@theacodes theacodes merged commit 16fd549 into wntrblm:master Jan 16, 2020
@theacodes
Copy link
Collaborator

Thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants