Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building universal wheels #293

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

schuderer
Copy link
Contributor

References

As described in #291, Nox ist still building universal wheels and publishing them to PyPI with the py2.py3 identifier in the wheel's file name.

What was changed

  • Remove setup.cfg outright (the bdist_wheel setting of universal = 1 was the only thing it contained)

Effects/tests

Tested as follows:

$ python setup.py sdist bdist_wheel  # wheel name is now marked as py3 instead of py2.py3
$ pip install dist/nox-2019.11.9-py3-none-any.whl
$ nox  # sucessfully runs it own tests
$ uninstall nox
$ pip install dist/nox-2019.11.9.tar.gz  # just to be safe
$ nox  # also still works, phew ;)

Copy link
Collaborator

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhermes dhermes merged commit 4d9e460 into wntrblm:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants