-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address #319: Give a create_tmp API #320
Conversation
Hi @theacodes ! This is a rough draft, but I want some feedback on how much in the wrong direction am I going. Is it reasonable to assume the bin directory is writable? Should we push this API to the specific virtualenv? Is it OK to fail if bin is None? Etc. |
This looks like a great start.
Yup.
Nope, I think even "virtualenvless" sessions will have use cases for the tmpdir.
I think this should work even if there's no virtualenv for the session. |
Hi @theacodes ! I added tests and documentation. I'm not sure if I understood your response to the third question -- do you mean I should have a tmpdir even without bin? In that case, I'm not sure the location would still make sense. |
Yup. I think it makes sense for it to go in |
OK, let me know what you think now. It should always work now. |
Looks good. 👌 |
@moshez I'd love to chat about this feature and how it relates to my use / abuse of |
@dhermes sent you an e-mail re: chatting about it. let me know! |
This doesn't have docs or tests! Hooray :)
It does however show one way to implement it (kinda hacky) and a working use case for further discussion.