-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for #180 #651
Add docs for #180 #651
Conversation
I have fixed the typo. The other failing tests looks like a temporary networking issue. |
@hynek thanks for sending this! There's actually an even easier way to accomplish the example shown: commit = session.run("git", "rev-parse", "--short", "HEAD", external=True, silent=True) |
aaargh now i understand Henry's comment. I never read the full help string b/c i didn't want silence. I guess i'll just rewrite example (but leave the new API docs)? 😅 |
Yeah that would be awesome. It's still a useful thing to document, I'd just
want it to have a more practical example.
…On Wed, Sep 14, 2022 at 10:46 AM Hynek Schlawack ***@***.***> wrote:
aaargh now i understand Henry's comment
<#218 (comment)>. I
never read the full help string b/c i didn't want silence.
I guess i'll just rewrite example (but leave the new API docs)? 😅
—
Reply to this email directly, view it on GitHub
<#651 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I4ZAQCAYBT3QEYGJKKLV6HQLPANCNFSM6AAAAAAQLHX4MA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Yeah, it's worthy to document this. The CI failed, so I decided to re-run the failed checks. Actually, I ran the CI for the latest commit. |
I've rewritten the example and clarified the arguments of stdout/stderr. I don't think they need their own examples; with silent=True they're rather fringe options. |
Thank you so much, @hynek! |
I found this extremely useful feature only by accident and Googling!
Not sure if y'all enjoy retroactive changelog editing…