Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check HTTP status code #7

Closed
johnjohndoe opened this issue Nov 12, 2023 · 0 comments · Fixed by #10
Closed

Check HTTP status code #7

johnjohndoe opened this issue Nov 12, 2023 · 0 comments · Fixed by #10
Assignees
@NWuensche
Labels
Feature request New feature or request Good first issue Good for newcomers Hacktoberfest Help wanted Extra attention is needed

Comments

@johnjohndoe
Copy link
Member

Context

A while ago the weekend markets URL in the open data portal changed. As a result the webserver redirected from https://daten.berlin.de/datensaetze/wochen-und-trödelmärkte to https://daten.berlin.de/datensaetze/wochen-und-tr%C3%B6delm%C3%A4rkte-0 when requesting the former. This was not noticed by the shell script because there are also dates shown. By coincidence the date matched with the date of the current deployment of https://wo-ist-markt.de/#berlin.

Proposal

To verify that the expected URL is still valid the shell script could check the HTTP status code returned by the webserver.
If the webserver returns something else than 200 an error can be raised.

Related
@johnjohndoe johnjohndoe added Feature request New feature or request Help wanted Extra attention is needed Hacktoberfest Good first issue Good for newcomers labels Nov 12, 2023
NWuensche added a commit that referenced this issue Nov 13, 2023
@NWuensche
Check status of daten.berlin.de
38a24c1 
Fixes #7
@johnjohndoe johnjohndoe mentioned this issue Dec 2, 2023
Merged
johnjohndoe pushed a commit that referenced this issue Dec 18, 2023
@NWuensche @johnjohndoe
Provide more specific sources of errors.
09fcf47 
+ Check status code of daten.berlin.de to notice redirects
+ Check if GeoJSON URL is present
+ Check if GeoJSON can be downloaded (status code)
+ Collect errors & output them at the end
+ Update README.md accordingly

Fixes #7
Fixes #8
Fixes #9
johnjohndoe added a commit that referenced this issue Dec 18, 2023
@johnjohndoe
Merge pull request #10 from wo-ist-markt/feature/#7_#8_#9
7afb00d 
Solve Issues #7 #8 #9
@johnjohndoe johnjohndoe mentioned this issue Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NWuensche NWuensche

Labels
Feature request New feature or request Good first issue Good for newcomers Hacktoberfest Help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide more specific sources of errors. wo-ist-markt/wo-ist-markt-berlin-update-reminder
2 participants
@johnjohndoe @NWuensche