Add support for deflate decompression #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for responses that were compressed using the `deflate` algorithm. As best I can tell, this isn't terribly common for servers to send in the wild—in my own usage of Req for scraping public sites, I see gzip and Brotli way, way more frequently. However, I think it's useful to have in Req for the sake of having decompression support that matches real browsers; Safari, Firefox, and Chrome each send an `Accept-Encoding` header of `gzip, deflate, br`.
s3cur3
commented
Nov 24, 2023
Comment on lines
+1346
to
+1353
| # uncompress/1 is used when the body *has* zlib headers and checksum | ||
| # unzip/1 works when the body has no headers or checksum. | ||
| unzipped = | ||
| try do | ||
| :zlib.uncompress(body) | ||
| rescue | ||
| ErlangError -> :zlib.unzip(body) | ||
| end |
There was a problem hiding this comment.
Someone with greater knowledge of the deflate representation could probably pattern match on the start of the body binary to determine if it had the header and checksum, but that's beyond me... 😬
Comment on lines
-714
to
+741
| |> Plug.Conn.put_resp_header("content-encoding", "deflate") | ||
| |> Plug.Conn.put_resp_header("content-encoding", non_existent_codec) |
There was a problem hiding this comment.
Now that we actually support deflate, we can't use it as an example of an unknown compression codec. 😄
|
yeah I'm happy to add it when someone actually needs but tbh I'm still unclear how exactly it should work. thanks for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Oh! I see this was intentionally removed in the past. Feel free to close!
This adds support for responses that were compressed using the
deflatealgorithm.As best I can tell, this isn't terribly common for servers to send in the wild—in my own usage of Req for scraping public sites, I see gzip and Brotli way, way more frequently. However, I think it's useful to have in Req for the sake of having decompression support that matches real browsers; Safari, Firefox, and Chrome each send an
Accept-Encodingheader ofgzip, deflate, br.