Add Req.Test.allow/3 #315
Merged
Add Req.Test.allow/3 #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
approved these changes
Feb 29, 2024
| @@ -72,6 +77,35 @@ defmodule Req.Test do | |||
|
|
|||
| assert MyApp.Weather.get_rating("Krakow, Poland") == {:ok, :nice} | |||
| end | |||
|
|
|||
| ### Concurrency and Allowances | |||
There was a problem hiding this comment.
This is great.
I believe explicit allowances are not necessary a lot of the time (Task, Task.Supervisor, controller and live view test helpers propagate $callers) so I don't want to leave an impression that it is always necessary when we spawn another process but I'm not sure how to document this best. Perhaps leave this vague that usually it's not necessary but if spawned process cannot find stub, it needs to be explicitly allowed.
There was a problem hiding this comment.
@wojtekmach that's a really good point. Rephrased, wdyt now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.