Add millisecond support #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, this PR got a bit cluttered because of all the changes on main branch, and also I've decided to take another approach with date-utils, so I reworked it in 8e32aa1 and marked you as a co-author. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with wojtekmaj/date-utils#74, this adds a new
useMilliseconds: booleanparameter toreact-clockthat allows it to show milliseconds as incremental angles, so the hands can move more smoothly instead of only snapping to seconds.This is primarily useful for stopwatch modes, like in this demo:
Screen.Recording.2023-06-19.at.12.05.03.PM.mov
Thanks!