Replace ESLint and Prettier with Biome

wojtekmaj · Jun 5, 2024 · 5df3d3d · 5df3d3d
1 parent 88eb85e
commit 5df3d3d
Show file tree

Hide file tree

Showing 22 changed files with 181 additions and 1,705 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,32 +18,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Cache Yarn cache
-        uses: actions/cache@v4
-        env:
-          cache-name: yarn-cache
-        with:
-          path: ~/.yarn/berry/cache
-          key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-${{ env.cache-name }}
-
-      - name: Use Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-
-      - name: Enable Corepack
-        run: corepack enable
-
-      - name: Install dependencies
-        run: yarn --immutable
-
-      - name: Build package
-        run: yarn build
+      - name: Setup Biome
+        uses: biomejs/setup-biome@v2
 
       - name: Run tests
-        run: yarn lint
+        run: biome lint
 
   typescript:
     name: Type checking
@@ -88,29 +67,11 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Cache Yarn cache
-        uses: actions/cache@v4
-        env:
-          cache-name: yarn-cache
-        with:
-          path: ~/.yarn/berry/cache
-          key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-${{ env.cache-name }}
-
-      - name: Use Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-
-      - name: Enable Corepack
-        run: corepack enable
-
-      - name: Install dependencies
-        run: yarn --immutable
+      - name: Setup Biome
+        uses: biomejs/setup-biome@v2
 
       - name: Run formatting
-        run: yarn format
+        run: biome format
 
   unit:
     name: Unit tests

diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1 +1 @@
-yarn lint-staged
+yarn format --staged --no-errors-on-unmatched --write
diff --git a/.lintstagedrc.json b/.lintstagedrc.json
diff --git a/.prettierignore b/.prettierignore
diff --git a/.prettierrc.json b/.prettierrc.json
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,4 +1,4 @@
 {
-  "recommendations": ["dbaeumer.vscode-eslint", "eamodio.gitlens", "esbenp.prettier-vscode"],
+  "recommendations": ["biomejs.biome", "eamodio.gitlens"],
   "unwantedRecommendations": ["dbaeumer.jshint"]
 }
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,5 +1,5 @@
 {
-  "editor.defaultFormatter": "esbenp.prettier-vscode",
+  "editor.defaultFormatter": "biomejs.biome",
   "editor.formatOnSave": true,
   "search.exclude": {
     "**/.yarn": true

diff --git a/biome.json b/biome.json
@@ -0,0 +1,43 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.8.0/schema.json",
+  "files": {
+    "ignore": [".tsimp", "coverage", "dist", ".pnp.cjs", ".pnp.loader.mjs"]
+  },
+  "formatter": {
+    "lineWidth": 100,
+    "indentStyle": "space"
+  },
+  "linter": {
+    "rules": {
+      "complexity": {
+        "noUselessSwitchCase": "off"
+      },
+      "suspicious": {
+        "noConsoleLog": "warn"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "quoteStyle": "single"
+    }
+  },
+  "overrides": [
+    {
+      "include": ["**/package.json"],
+      "formatter": {
+        "lineWidth": 1
+      }
+    },
+    {
+      "include": ["**/vite.config.ts"],
+      "linter": {
+        "rules": {
+          "suspicious": {
+            "noConsoleLog": "off"
+          }
+        }
+      }
+    }
+  ]
+}
diff --git a/package.json b/package.json
@@ -18,12 +18,7 @@
     "unit": "yarn workspaces foreach --all run unit"
   },
   "devDependencies": {
-    "husky": "^9.0.0",
-    "lint-staged": "^15.0.0",
-    "prettier": "^3.2.0"
-  },
-  "resolutions": {
-    "eslint-plugin-import": "npm:eslint-plugin-i@^2.28.0"
+    "husky": "^9.0.0"
   },
   "packageManager": "yarn@4.1.1"
 }
diff --git a/packages/react-fit/.eslintignore b/packages/react-fit/.eslintignore
diff --git a/packages/react-fit/.eslintrc.json b/packages/react-fit/.eslintrc.json
diff --git a/packages/react-fit/.prettierignore b/packages/react-fit/.prettierignore
diff --git a/packages/react-fit/package.json b/packages/react-fit/package.json
@@ -18,8 +18,8 @@
     "build-cjs": "tsc --project tsconfig.build.json --outDir dist/cjs --module commonjs --moduleResolution node --verbatimModuleSyntax false",
     "build-cjs-package": "echo '{\n  \"type\": \"commonjs\"\n}' > dist/cjs/package.json",
     "clean": "rimraf dist",
-    "format": "prettier --check . --cache",
-    "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
+    "format": "biome format",
+    "lint": "biome lint",
     "prepack": "yarn clean && yarn build",
     "test": "yarn lint && yarn tsc && yarn format && yarn unit",
     "tsc": "tsc",
@@ -42,15 +42,13 @@
     "warning": "^4.0.0"
   },
   "devDependencies": {
+    "@biomejs/biome": "^1.8.0",
     "@testing-library/dom": "^10.0.0",
     "@testing-library/jest-dom": "^6.0.0",
     "@testing-library/react": "^15.0.0",
     "@types/react": "*",
     "@types/warning": "^3.0.0",
-    "eslint": "^8.56.0",
-    "eslint-config-wojtekmaj": "^1.0.0",
     "happy-dom": "^12.6.0",
-    "prettier": "^3.2.0",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "rimraf": "^3.0.0",

diff --git a/packages/react-fit/src/Fit.tsx b/packages/react-fit/src/Fit.tsx
@@ -140,7 +140,7 @@ function alignAxis({
     const moreSpaceStart = availableStartSpace > availableEndSpace;
 
     const rawMinSize = style.getPropertyValue(minSizeProperty);
-    const minSize = rawMinSize ? parseInt(rawMinSize, 10) : null;
+    const minSize = rawMinSize ? Number.parseInt(rawMinSize, 10) : null;
 
     function shrinkToSize(size: number) {
       warning(
@@ -165,7 +165,7 @@ function alignAxis({
     }
   }
 
-  let fits;
+  let fits: boolean;
 
   if (invertAxis) {
     fits = displayStartIfFits() || displayEndIfFits();

diff --git a/packages/react-fit/tsconfig.json b/packages/react-fit/tsconfig.json
@@ -10,7 +10,7 @@
     "outDir": "dist",
     "skipLibCheck": true,
     "strict": true,
-    "target": "es5",
+    "target": "es2015",
     "verbatimModuleSyntax": true
   },
   "exclude": ["dist"]

diff --git a/test/.eslintignore b/test/.eslintignore
diff --git a/test/.eslintrc.json b/test/.eslintrc.json
diff --git a/test/.prettierignore b/test/.prettierignore
diff --git a/test/ElementWithPopover.tsx b/test/ElementWithPopover.tsx
@@ -46,11 +46,11 @@ export default function ElementWithPopover({
 
             requestAnimationFrame(() => {
               const style: Record<string, unknown> = {};
-              (['top', 'bottom', 'left', 'right'] as const).forEach((prop) => {
+              for (const prop of ['top', 'bottom', 'left', 'right'] as const) {
                 if (ref.style[prop]) {
                   style[prop] = ref.style[prop];
                 }
-              });
+              }
 
               const el = ref.querySelector('pre[id="style"]') as HTMLElement;
               el.innerHTML = JSON.stringify(style, null, '  ');

diff --git a/test/Test.tsx b/test/Test.tsx
@@ -2,8 +2,6 @@ import './Test.css';
 
 import ElementWithPopover from './ElementWithPopover.js';
 
-/* eslint-disable react/no-unused-prop-types */
-
 const BUTTON_WIDTH = 130;
 const BUTTON_HEIGHT = 42;
 const MARGIN = 10;

diff --git a/test/package.json b/test/package.json
@@ -7,8 +7,8 @@
   "scripts": {
     "build": "vite build",
     "dev": "vite",
-    "format": "prettier --check . --cache",
-    "lint": "eslint . --ext .js,.jsx,.ts,.tsx",
+    "format": "biome format",
+    "lint": "biome lint",
     "preview": "vite preview",
     "test": "yarn lint && yarn tsc && yarn format",
     "tsc": "tsc"
@@ -25,11 +25,9 @@
     "react-fit": "workspace:packages/react-fit"
   },
   "devDependencies": {
+    "@biomejs/biome": "^1.8.0",
     "@types/react": "*",
     "@vitejs/plugin-react": "^4.2.0",
-    "eslint": "^8.56.0",
-    "eslint-config-wojtekmaj": "^1.0.0",
-    "prettier": "^3.2.0",
     "typescript": "^5.4.2",
     "vite": "^5.0.0"
   }