Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some silkscreen symbols are not being rendered completely #15

Closed
mtiutiu opened this issue Jan 30, 2020 · 5 comments
Closed

Some silkscreen symbols are not being rendered completely #15

mtiutiu opened this issue Jan 30, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mtiutiu
Copy link

mtiutiu commented Jan 30, 2020

Description:
Seems that some symbols present on the PCB silkscreen (top and/or bottom) are not converted completely leading to an incomplete drawing. See the "high voltage symbols" in the attached pictures.

Expected result:
Any silkscreen symbols should be fully translated.

Original:
Screenshot from 2020-01-29 15-34-47

Conversion result:
Screenshot from 2020-01-30 09-30-27

Project files:
project.zip

KiCAD version (latest stable): 5.1.5
easyeda2kicad version: 1.3.4

If any other details are needed please let me know.
Thanks.

@urish
Copy link
Collaborator

urish commented Feb 3, 2020

Can you please check again with latest version from master?

@mtiutiu
Copy link
Author

mtiutiu commented Feb 4, 2020

@urish

Hi, the conversion process is crashing with an exception now:

/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:319
    var isSmd = shapes.some(function (shape) { return shape[0] === 'pad' && shape[2] === 'smd'; });
                                                           ^

TypeError: Cannot read property '0' of null
    at /home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:319:60
    at Array.some (<anonymous>)
    at convertLib (/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:319:24)
    at convertShape (/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:391:21)
    at /home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:403:148
    at Array.map (<anonymous>)
    at Object.convertBoard (/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:403:118)
    at Object.<anonymous> (/home/mtiutiu/Tmp/easyeda2kicad/dist/main.js:17:84)

@urish
Copy link
Collaborator

urish commented Feb 4, 2020

Should be fixed by #20, can you give it another go?

@mtiutiu
Copy link
Author

mtiutiu commented Feb 4, 2020

Yep. Works now as expected. See attached picture.
Screenshot from 2020-02-04 10-57-32

@urish
Copy link
Collaborator

urish commented Feb 4, 2020

Awesome! released as 1.4.0

@urish urish closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants