Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-GND solid regions are missing after conversion #17

Closed
mtiutiu opened this issue Jan 30, 2020 · 9 comments
Closed

Non-GND solid regions are missing after conversion #17

mtiutiu opened this issue Jan 30, 2020 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@mtiutiu
Copy link

mtiutiu commented Jan 30, 2020

Description:
If I have in the original design a solid copper region created say for a MOSFET cooling and/or for high current paths which are not tied to GND then those aren't being translated.

Expected result:
The solid region tied to MOSFET drain pad should be present on both sides of the PCB.

See attached pictures.

Original:
original

Another two pictures (top/bottom) for reference:
Screenshot from 2020-01-30 10-01-03
Screenshot from 2020-01-30 10-00-45

Conversion result:
Screenshot from 2020-01-30 09-49-46

Project files:
project.zip

KiCAD version (latest stable): 5.1.5
easyeda2kicad version: 1.3.4

If any other details are needed please let me know.
Thanks.

@mtiutiu mtiutiu changed the title Non GND solid regions are missing after conversion Non-GND solid regions are missing after conversion Jan 30, 2020
@urish urish added the bug Something isn't working label Jan 30, 2020
@urish
Copy link
Collaborator

urish commented Jan 30, 2020

Could be related to #15

@urish urish self-assigned this Jan 31, 2020
@mtiutiu
Copy link
Author

mtiutiu commented Feb 4, 2020

@urish #15 seems to be fixed now and the symbols are rendered correctly.
The solid region is still missing though.

@urish
Copy link
Collaborator

urish commented Feb 4, 2020

Right, I'll look into this over the next few days

@urish
Copy link
Collaborator

urish commented Feb 4, 2020

How about now?

@mtiutiu
Copy link
Author

mtiutiu commented Feb 4, 2020

Yes sir - that's the spirit! Works like magic now. Thanks a lot.

One small issue is present but that's fixable by hand. It seems that the vias inside that solid region even if they have associated the same net name still don't want to connect.

Other than that - respect!!!

Screenshot from 2020-02-04 12-24-19

Vias appear like not being connected:
Screenshot from 2020-02-04 12-27-32

@urish
Copy link
Collaborator

urish commented Feb 4, 2020

Thanks for the super-quick feedback!

Yes, I was looking in KiCad, but it seems like they do not support setting the net names for polygons (I even tried adding a net attribute, but it failed so I commented that out). If you do find a way to do this via KiCad UI, let me know and I will look how to implement it.

@mtiutiu
Copy link
Author

mtiutiu commented Feb 4, 2020

@urish I think this ticket can be closed as the initial issue was solved. The rest..well maybe other tickets if it's the case.

@urish urish closed this as completed Feb 4, 2020
@mtiutiu
Copy link
Author

mtiutiu commented Feb 4, 2020

@urish can we have a new release including this fix also if not already there? Thanks.

@urish
Copy link
Collaborator

urish commented Feb 4, 2020

Sure, released as 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants