Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the deprecation warning #66

Closed
wants to merge 1 commit into from

Conversation

safiyat
Copy link
Collaborator

@safiyat safiyat commented Jun 1, 2017

Fixes the warning:
DEPRECATION: pip install --download has been deprecated and will be removed in
the future. Pip now has a download command that should be used instead.

screen shot 2017-06-01 at 09 10 49

Uses the new pip download command instead of the deprecated pip install.

"DEPRECATION: pip install --download has been deprecated and will be removed in
 the future. Pip now has a download command that should be used instead."

Uses the new `pip download` command instead of the deprecated `pip install`.
@safiyat safiyat changed the title Fixes the deprecation warning: Fixes the deprecation warning Jun 7, 2017
Copy link

@Jay54520 Jay54520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original command is pip install -d, means -d, --download <dir> Download packages into <dir> instead of installing them, regardless of what's already installed.
You should update to pip download, the -d should be removed.

According to https://pip.pypa.io/en/stable/reference/pip_download/.

@Jay54520
Copy link

Jay54520 commented Jan 22, 2018

I also create a issue -- #71 for this. When the merge request is accepted, the issue should be closed. So your description should change to Fixes #71/Fixes the deprecation warning

@safiyat
Copy link
Collaborator Author

safiyat commented Jan 29, 2018

@Jay54520 The -d option is to specify the destination directory.

Please check: https://pip.pypa.io/en/stable/reference/pip_download/#cmdoption-d

@Jay54520
Copy link

@safiyat Yes, same effect between pip install -d and pip download -d, I have no problem with the pull request.

@safiyat
Copy link
Collaborator Author

safiyat commented Apr 17, 2018

Closing in favour of #75

@safiyat safiyat closed this Apr 17, 2018
@safiyat safiyat deleted the fix_deprecated_warning branch November 14, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants