Fixed issues caused due to upgrade of pip to v10.0.0 #75
Conversation
…e deprecated `pip install --download` support. Among other changes, - Introduced a set of global variables named `pip_version`, `pip_download_command` and `pip_no_binary_command`. The variables `pip_download_command` and `pip_no_binary_command` are version dependent. - Now we are importing the `main()` method from `pip` (for pip<10.0.0) or from `pip._internal` (for pip>=10.0.0) as `pip_main`. - Introduced a new flag `has_pip` (pretty much like `has_wheel`) as a global flag to denote the presence of pip. - The help messages printed by the pip2pi parser now dynamically prints options for pip download and no-binary features based on installed pip version.
|
@wolever @themartorana Please take a look. |
|
@safiyat sent you a PR to get travis tests to run green with this branch. |
Get Travis CI tests to run properly.
|
Thanks to @sinemetu1, the Travis CI test configuration is fixed too. |
|
@wolever bump |
|
@wolever Any chance of merging this soon? |
|
@wolever can we get this merged in and cut a release? |
|
@wolever You still around? Can we please get this merged? |
|
@wolever Ughhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh wtf 🤔 |
|
Ug, I'm very sorry. I have no excuse for why this took so long. If there is a general consensus that this is functional, I'm happy to merge. Additionally, if any of y'all would like to take over maintenance, send me your PyPI usernames and I'll give you access to the repository. Again, I'm very sorry for how long this has taken. While it definitely doesn't make up for it, if you'd like to send me your mailing addresses, I'll send you some PyCon Canada swag. |
|
@wolever I think the first thing to be done is to get this merged. Others have approved the change. You may review it too if you like. You may provide access to me if you like. The pypi username is PyCon swag? All may be forgiven. Check mail. |
|
@wolever Cool to have you back! |
|
So I ran the UTs for all the versions of Will fix this first, and then get it merged. |
|
Looks like all the tests pass … Can we merge this? Pretty please with sugar on top? ☺ I really want to get this installed on my work set up to stop the crazy™ system we use… |
safiyat
force-pushed
the
add__pip.10.0.0_support
branch
2 times, most recently
from
0dbaecd
to
cd1abbc
Compare
…ution of each pip command. When populated by one `pip_main` call, the variable remains in the environment properties for all subsequent calls, wreaking havoc since the directory is subsequently deleted. Should be removed once fixed in `pip`, but will remain until then. Also removed testing for py33 as pip 18.1 demands 3.4.
safiyat
force-pushed
the
add__pip.10.0.0_support
branch
from
cd1abbc
to
0972eaf
Compare
|
The issue was the introduction of an environment variable Also, apologies for this delay in the fix. I'll try not to keep things hanging for so long in the future. |
|
@sinemetu1 @kierun @zulrang pip2pi v0.8.0-rc1 is released. I have tested it as much as I could. Please provide your feedback so that we can do a final release. |
|
I just tried |
|
@philipp2100 Is it possible for you to test #85 for your use case? If it is, could you please test it and report whether it works for you? |
|
Yes, that patch also fixes it. |
Fixed issues caused due to upgrade of pip to v10.0.0 which removed the deprecated
pip install --downloadsupport.Among other changes,
pip_version,pip_download_commandandpip_no_binary_command. The variablespip_download_commandandpip_no_binary_commandare version dependent.main()method frompip(for pip<10.0.0) or frompip._internal(for pip>=10.0.0) aspip_main.has_pip(pretty much likehas_wheel) as a global flag to denote the presence of pip.Tested with pip versions 7.0.0 and onwards. Two unit tests of normalized names fail with pip versions 8.0.0, 8.1.0 and 8.1.1 as they did earlier.