Edge labels should rely on Labels type, not string (#175)

wolf4ood · Feb 19, 2023 · 7f991f3 · 7f991f3
1 parent 6f3c8e3
commit 7f991f3
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/gremlin-client/src/process/traversal/anonymous_traversal_source.rs b/gremlin-client/src/process/traversal/anonymous_traversal_source.rs
@@ -55,7 +55,7 @@ impl AnonymousTraversalSource {
 
     pub fn add_e<A>(&self, label: A) -> TraversalBuilder
     where
-        A: Into<String>,
+        A: Into<Labels>,
     {
         self.traversal.clone().add_e(label)
     }

diff --git a/gremlin-client/src/process/traversal/builder.rs b/gremlin-client/src/process/traversal/builder.rs
@@ -167,10 +167,12 @@ impl TraversalBuilder {
 
     pub fn add_e<A>(mut self, label: A) -> Self
     where
-        A: Into<String>,
+        A: Into<Labels>,
     {
-        self.bytecode
-            .add_step(String::from("addE"), vec![label.into().into()]);
+        self.bytecode.add_step(
+            String::from("addE"),
+            label.into().0.into_iter().map(GValue::from).collect(),
+        );
 
         self
     }

diff --git a/gremlin-client/src/process/traversal/graph_traversal.rs b/gremlin-client/src/process/traversal/graph_traversal.rs
@@ -186,7 +186,7 @@ impl<S, E: FromGValue, T: Terminator<E>> GraphTraversal<S, E, T> {
 
     pub fn add_e<A>(mut self, label: A) -> GraphTraversal<S, Edge, T>
     where
-        A: Into<String>,
+        A: Into<Labels>,
         T: Terminator<Edge>,
     {
         self.builder = self.builder.add_e(label);

diff --git a/gremlin-client/src/process/traversal/graph_traversal_source.rs b/gremlin-client/src/process/traversal/graph_traversal_source.rs
@@ -81,12 +81,15 @@ impl<A: Terminator<GValue>> GraphTraversalSource<A> {
 
     pub fn add_e<T>(&self, label: T) -> GraphTraversal<Edge, Edge, A>
     where
-        T: Into<String>,
+        T: Into<Labels>,
         A: Terminator<Edge>,
     {
         let mut code = Bytecode::new();
 
-        code.add_step(String::from("addE"), vec![label.into().into()]);
+        code.add_step(
+            String::from("addE"),
+            label.into().0.into_iter().map(GValue::from).collect(),
+        );
 
         GraphTraversal::new(self.term.clone(), TraversalBuilder::new(code))
     }