Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AsyncTerminator publicly #123

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

lberezy
Copy link
Contributor

@lberezy lberezy commented Jan 21, 2021

Resolves #122

@wolf4ood wolf4ood merged commit 81f736e into wolf4ood:master Feb 5, 2021
@wolf4ood
Copy link
Owner

wolf4ood commented Feb 5, 2021

@lberezy sorry for the delay

Thanks :)

@criminosis
Copy link
Contributor

criminosis commented Jun 29, 2021

@wolf4ood how does one invoke a use statement to get AsyncTerminator?

Doing this use gremlin_client::aio::process::traversal::remote::AsyncTerminator yields:

error[E0603]: module `process` is private
 --> src/lib.rs:8:26
  |
8 | use gremlin_client::aio::process::traversal::remote::AsyncTerminator;
  |                          ^^^^^^^ private module

It almost feels like the aio module's mod file should have something like pub use process::traversal::AsyncTerminator; in this PR? Still getting the hang of Rust though, not sure if that would then conflict with pub(crate) mod process;

Ultimately I'm trying to do something like this:

fn get_traversal(&self) ->  GraphTraversalSource<AsyncTerminator>{
        traversal().with_remote_async(self.client.clone())
    }

That is a method on a struct I've written that is wrapping a GremlinClient to handle some common execution query logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncTerminator not public like SyncTerminator
3 participants