Fixed precision of g:Date values to milliseconds #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criminosis
commented
Mar 31, 2021
| @@ -59,10 +59,10 @@ impl GraphSON { | |||
| "@type" : "g:UUID", | |||
| "@value" : s.to_string() | |||
| })), | |||
| (GraphSON::V1, GValue::Date(d)) => Ok(json!(d.timestamp())), | |||
| (GraphSON::V1, GValue::Date(d)) => Ok(json!(d.timestamp_millis())), | |||
There was a problem hiding this comment.
Touching the GraphSON V1 implementation is something I flip-flopped on since as far as I can tell in the [docs] (http://tinkerpop.apache.org/docs/current/dev/io/#graphson-1d0) there is no spec definition for a date, it's just some integer value, which seems consistent with the test I ended up modifying in gremlin-client/tests/integration_client_v1.rs.
In that test the value is parsed out as a i64 so I think there's an argument to be made that there is no millisecond precision expectation in the v1 standard so it could be left as is as epoch second but for now I went for consistency with v2 and v3. Let me know if you feel like I should have left v1 alone @wolf4ood
|
Thanks 👍 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
This PR is a breaking change upon dates that are currently serialized since they would be serialized as epoch seconds not epoch milliseconds, but the Tinkerpop standard for version 2 and version 3 expects milliseconds.
Given the library is still major version 0 such breaking changes are permitted per semver expectations, but wanted to call it out for your consideration when reviewing.