Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Type Conversions #147

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Collection Type Conversions #147

merged 2 commits into from
Jan 20, 2022

Conversation

maldrake
Copy link
Contributor

As I'm working with gremlin-rs, I've noticed that I had to write a handful of helper functions to shuffle collections from GValue types back and forth with standard library collection types based on Vec and HashMap. This pull request proposes to add a few more From and TryFrom implementations to gremlin-rs types as a convenience feature.

@maldrake
Copy link
Contributor Author

Also, @wolf4ood, assuming this PR is agreeable, would it be asking a lot to have a new release pushed to crates.io? Last time we talked, I didn't have any pressing need. At this point, having the close_session and connection testing code that was merged in June would help me close out some development branches on other projects. As always, thank you for all the time and effort that has gone into gremlin-rs. I'm getting a lot of great use out of it.

Copy link
Owner

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maldrake thanks :)
LGTM

@wolf4ood wolf4ood merged commit 3fa5dea into wolf4ood:master Jan 20, 2022
@wolf4ood
Copy link
Owner

@maldrake 0.8.1 released :)

https://crates.io/crates/gremlin-client

@maldrake
Copy link
Contributor Author

Fantastic. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants