Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sideEffect step #183

Merged
merged 1 commit into from
Apr 4, 2023
Merged

add sideEffect step #183

merged 1 commit into from
Apr 4, 2023

Conversation

OmriSteiner
Copy link
Contributor

@OmriSteiner OmriSteiner commented Mar 30, 2023 •
edited

Adding the sideEffect step, as it's missing.

Edit: just noticed this: #164

@OmriSteiner OmriSteiner changed the title add sideEffect step add sideEffect step (issue #164) Mar 31, 2023
@OmriSteiner OmriSteiner changed the title add sideEffect step (issue #164) add sideEffect step Mar 31, 2023
wolf4ood
wolf4ood reviewed Apr 4, 2023
View reviewed changes
Copy link
Owner

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OmriSteiner

thanks for this PR could you check the formatter?

@OmriSteiner
Copy link
Contributor Author

@wolf4ood Done

@wolf4ood wolf4ood merged commit 543ba55 into wolf4ood:master Apr 4, 2023
4 checks passed
@wolf4ood
Copy link
Owner

wolf4ood commented Apr 4, 2023

Thanks @OmriSteiner

@wolf4ood wolf4ood mentioned this pull request Apr 4, 2023
Closed
@OmriSteiner OmriSteiner deleted the side-effect-step branch April 4, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OmriSteiner @wolf4ood