Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mosquitto OSP #145

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Add mosquitto OSP #145

merged 2 commits into from
Jun 10, 2024

Conversation

embhorn
Copy link
Member

@embhorn embhorn commented May 31, 2023

Adds wolfSSL support to Mosquitto 2.0.18

See README.md for build instructions

@embhorn embhorn self-assigned this May 31, 2023
mosquitto/2.0.15.patch Outdated Show resolved Hide resolved
mosquitto/2.0.15.patch Outdated Show resolved Hide resolved
mosquitto/2.0.15.patch Outdated Show resolved Hide resolved
@embhorn embhorn force-pushed the mosquitto-port branch 2 times, most recently from 5d9c535 to 632efa8 Compare June 1, 2023 21:16
Copy link
Contributor

@kareem-wolfssl kareem-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.
Seeing some test failures as we discussed on Slack. Since some tests are also failing with OpenSSL, the patch file/README should clarify that some tests are expected to fail (and ideally which)
Would be great to fix the unique wolfSSL test failures if possible.

@julek-wolfssl
Copy link
Member

It would be nice to add a github action for this OSP to wolfMQTT.

@embhorn
Copy link
Member Author

embhorn commented Jun 12, 2023

How would that work exactly? We already test wolfMQTT against Mosquitto (built with OpenSSL).

@julek-wolfssl
Copy link
Member

You're right. Mosquitto is being linked against wolfSSL so it should be tested in the wolfSSL PRB tests.

Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just one improvement.

mosquitto/2.0.18.patch Outdated Show resolved Hide resolved
@julek-wolfssl julek-wolfssl merged commit fac3708 into wolfSSL:master Jun 10, 2024
@embhorn
Copy link
Member Author

embhorn commented Jun 10, 2024

Tabs-to-spaces from my editor messed up the patch file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants