Update autoconf M4 files #71
Conversation
* Update several of the macro files paralleling wolfSSL's m4 files. * Force the `AR_FLAGS` to be `cr` in `configure.ac`. * Add the `-Xcompiler` flag ahead of `-Qunused-arguments` for `-pthreads`.
…ssl library detection.
…ion of configuration options in `wolfmqtt/options.h`. Cleanup of the configure.ac to use AM_CFLAGS and remove AX_PTHREAD.
configure.ac
Outdated
| @@ -34,6 +38,11 @@ WOLFMQTT_LIBRARY_VERSION=2:0:0 | |||
| # +- increment if interfaces have been added, removed or changed | |||
| AC_SUBST([WOLFMQTT_LIBRARY_VERSION]) | |||
|
|
|||
| # capture user C_EXTRA_FLAGS from ./configure line, CFLAGS may hold -g -O2 even | |||
| # if user doesn't override, no way to tell | |||
There was a problem hiding this comment.
Up on line 11 and line 14, we know why CFLAGS gets default values. It is due to AC_PROG_CC. Line 11 is the idiom for initializing a shell variable when the caller doesn't pass one in. AC_PROG_CC won't add "-g -O2" because of that, then we tack in on later as appropriate.
… Fix to hush ar warning (adds the "U" option to the ar flags if the version of ar supports it).
configure.ac
Outdated
| @@ -11,7 +11,10 @@ AC_CONFIG_AUX_DIR([build-aux]) | |||
| # The following sets CFLAGS and CXXFLAGS to empty if unset on command line. | |||
| : ${CFLAGS=""} | |||
| : ${CXXFLAGS=""} | |||
There was a problem hiding this comment.
I'd get rid of this. It doesn't hurt anything, but you aren't using an C++ compilers. Even if you set CC=clang++, configure will treat clang++ as a C compiler and only use the CFLAGS.
| @@ -227,7 +227,6 @@ | |||
| ]) | |||
|
|
|||
| AC_DEFUN([AX_CC_OTHER_FLAGS], [ | |||
| AC_REQUIRE([AX_APPEND_COMPILE_FLAGS]) | |||
There was a problem hiding this comment.
Good catch. I need to fix this over at wolfSSH. AC_REQUIRE forces use of the macro, not checking if it is present.
configure.ac
Outdated
| @@ -52,8 +54,8 @@ AC_PROG_INSTALL | |||
|
|
|||
| # Checks for header files. | |||
| AC_HEADER_STDC | |||
| AC_CHECK_SIZEOF([long long], 8) | |||
| AC_CHECK_SIZEOF([long], 4) | |||
| AC_CHECK_SIZEOF(long long, 8) | |||
There was a problem hiding this comment.
The brackets should be there. The parameters to the macros should be quoted with the brackets. Also, AC_CHECK_SIZEOF only takes a single parameter, the type name. The 4 and 8 are ignored.
There was a problem hiding this comment.
Or the brackets don't hurt. They aren't necessary in every case, but they work in every case. I found it easier to put them in then to try to remember the exception cases.
configure.ac
Outdated
| AC_INIT([wolfmqtt],[1.0.0],[https://github.com/wolfssl/wolfMQTT/issues],[wolfmqtt],[http://www.wolfssl.com]) | ||
|
|
||
| AC_PREREQ([2.63]) | ||
| AC_CONFIG_AUX_DIR([build-aux]) | ||
|
|
||
| : ${CFLAGS=""} | ||
| : ${AR_FLAGS="cr"} | ||
|
|
||
| AC_CANONICAL_HOST | ||
| AC_CANONICAL_BUILD |
There was a problem hiding this comment.
The autoconf manual states that you should only use one of AC_CANONICAL_HOST, AC_CANONICAL_BUILD, or AC_CANONICAL_TARGET. wolfSSL has listed both, and only the HOST is expanded in the configure script, BUILD has been ignored. (I'm not sure which one we really need, wolfSSL has always had two of them so we've always had a "canonical host" since Brian added autotools.)
ejohnstown
dismissed
their stale review
Things changed, and I had comments on them.
…Cleanup the `AC_CHECK_FUNCS` and `AC_CHECK_LIB`.
LPC: Fix aligned page address write
./configure --enable-debug=verboseto also set the debug flags.