Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix div implementation in SP int #3087

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fix div implementation in SP int #3087

merged 1 commit into from
Jul 14, 2020

Conversation

SparkiDev
Copy link
Contributor

No description provided.

@SparkiDev SparkiDev self-assigned this Jun 30, 2020
@SparkiDev SparkiDev force-pushed the sp_math_mod branch 2 times, most recently from f9f4df1 to 3aceee3 Compare July 1, 2020 23:24
@guidovranken
Copy link
Contributor

@SparkiDev

This breaks clang x86 (32 bit) compilation:

CC=clang CFLAGS="-m32" ./configure --enable-static --disable-examples --disable-crypttests --enable-sp --enable-sp-math && make -j12

wolfcrypt/src/sp_int.c:931:33: error: implicit conversion loses integer precision: 'sp_int_sword' (aka 'long long') to 'sp_int_digit' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                sa->dp[j + o] = sw;

@SparkiDev
Copy link
Contributor Author

Add cast on line.
Thanks @guidovranken!

@SparkiDev SparkiDev assigned guidovranken and unassigned SparkiDev Jul 5, 2020
@SparkiDev SparkiDev assigned toddouska and unassigned guidovranken Jul 13, 2020
@toddouska toddouska merged commit 2dcf4c1 into wolfSSL:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddouska toddouska toddouska approved these changes

Assignees

@toddouska toddouska

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SparkiDev @guidovranken @toddouska