adjust PKCS7_VerifySignedData to correctly verify precomputed content hash with detached signature #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see we have some wc_PKCS7_VerifySignedData_ex tests in tests/api.c. If the test case is succeeding without this change do we need to make some updates to what we are testing or add an additional test to avoid regressions? |
… hash with detached signature
…ure and content digest only
cconlon
force-pushed
the
pkcs7_detachedhash
branch
from
f53b920
to
a8b6304
Compare
|
@JacobBarthelmeh test added, ready for review |
JacobBarthelmeh
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the PKCS7_VerifySignedData() function in pkcs7.c to correctly verify a SignedData detached signature bundle where the user passes in a pre-computed content message digest into wc_PKCS7_VerifySignedData_ex().
There are two options for users verifying a detached PKCS7 SignedData signature. They can set pkcs7->content and pkcs7->contentSz before calling wc_PKCS7_VerifySignedData(), and wolfSSL will compute the content message digest internally. Or, for users who do not have the entire content up front, they can create the content message digest on their own and pass that to wc_PKCS7_VerifySignedData_ex(). This fixes the later use case.